Re: [Qemu-ppc] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property

[Andreas Färber]

Am 14.11.2013 06:20, schrieb Alexey Kardashevskiy:
> On 11/12/2013 12:31 AM, Andreas Färber wrote:
>> 2) Please move the array out of the function to just before the
>> containing function.
> 
> Again, this is just to show. But. Why do you want those properties to be
> outside of the function? Less visibility is usually a good thing, no?

We used to have ->props = (...[]) {...}; and Anthony specifically
refactored it to have a static variable one level down, just before the
function assigning it. It was a scripted conversion in the context of
QOM introduction, maybe the archives will give you insight about why
exactly it was done.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg