[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] mmu-hash64: fix Virtual Page Class Key Protection
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-ppc] [PATCH] mmu-hash64: fix Virtual Page Class Key Protection |
|
Date: |
Wed, 5 Feb 2014 10:04:06 +0100 |
On 04.02.2014, at 18:21, Cédric Le Goater <address@hidden> wrote:
> commit f80872e21c07edd06eb343eeeefc8af404b518a6 (mmu-hash64: Implement
> Virtual Page Class Key Protection) added a new page protection
> mechanism based on page keys and the AMR register to control access.
>
> The AMR register allows or prohibits reads and/or writes on a page
> depending on the control bits associated to the key. A store or a load
> is only permitted if the associate bit is 0 (Power ISA), and not 1 as
> the code is currently doing. This patch modifies ppc_hash64_amr_prot()
> to correct the protection check.
>
> This issue was unvailed by commit ccfb53ed6360cac0d5f6f7915ca9ae7eed866412
> (target-ppc: fix Authority Mask Register init value) which changed the
> initialisation value of the AMR register to 0.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
Nice catch. Thanks a lot, applied to ppc-next.
Alex