|
| From: | Alex Bennée |
| Subject: | Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit |
| Date: | Tue, 25 Mar 2014 07:29:01 +0000 |
| User-agent: | mu4e 0.9.9.6pre2; emacs 24.3.50.2 |
Anton Blanchard <address@hidden> writes: > Add MSR_LE to the msr_mask for POWER8. > <snip> > - pcc->msr_mask = 0x800000000284FF36ULL; > + pcc->msr_mask = 0x800000000284FF37ULL; <snip> Should we be adding some #define's for the various bit positions on this mask? Looking at the current code it looks like a big ream of magic numbers. Cheers, -- Alex Bennée
| [Prev in Thread] | Current Thread | [Next in Thread] |