Re: [Qemu-ppc] [Qemu-devel] [PATCH 12/12] linux-user: writev Partial Writes

[Peter Maydell]

On 4 August 2014 17:45, Tom Musta <address@hidden> wrote:
> Although not technically not required by POSIX, the writev system call will
> typically write out its buffers individually.  That is, if the first buffer
> is written successfully, but the second buffer pointer is invalid, then
> the first chuck will be written and its size is returned.
>
> Signed-off-by: Tom Musta <address@hidden>
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index fea54be..19e78dc 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1798,6 +1798,7 @@ static struct iovec *lock_iovec(int type, abi_ulong 
> target_addr,
>      abi_ulong total_len, max_len;
>      int i;
>      int err = 0;
> +    int bad_address = 0;

I would use a bool here rather than int. Other than that nit,


Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM