[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH v2 01/13] qom: Make object_child_foreach safe
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [RFC PATCH v2 01/13] qom: Make object_child_foreach safe for objects removal |
Date: |
Tue, 19 Aug 2014 10:39:49 +1000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Aug 15, 2014 at 08:12:23PM +1000, Alexey Kardashevskiy wrote:
> Current object_child_foreach() uses QTAILQ_FOREACH() to walk
> through children and that makes children removal from the callback
> impossible.
>
> This makes object_child_foreach() use QTAILQ_FOREACH_SAFE().
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
Seems like a good idea to me.
Reviewed-by: David Gibson <address@hidden>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpfCz1kyBM4E.pgp
Description: PGP signature
- Re: [Qemu-ppc] [RFC PATCH v2 05/13] spapr_pci: Introduce a liobn number generating macros, (continued)
- [Qemu-ppc] [RFC PATCH v2 08/13] spapr_pci: Enable DDW, Alexey Kardashevskiy, 2014/08/15
- [Qemu-ppc] [RFC PATCH v2 01/13] qom: Make object_child_foreach safe for objects removal, Alexey Kardashevskiy, 2014/08/15
- Re: [Qemu-ppc] [RFC PATCH v2 01/13] qom: Make object_child_foreach safe for objects removal,
David Gibson <=
- [Qemu-ppc] [RFC PATCH v2 02/13] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows, Alexey Kardashevskiy, 2014/08/15
- [Qemu-ppc] [RFC PATCH v2 07/13] spapr_rtas: Add Dynamic DMA windows (DDW) RTAS calls support, Alexey Kardashevskiy, 2014/08/15
- [Qemu-ppc] [RFC PATCH v2 09/13] spapr_pci_vfio: Call spapr_pci::reset on reset, Alexey Kardashevskiy, 2014/08/15