qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v3 5/7] sysbus: Add new platform bus helper device


From: Paolo Bonzini
Subject: Re: [Qemu-ppc] [PATCH v3 5/7] sysbus: Add new platform bus helper device
Date: Fri, 26 Sep 2014 14:44:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

Il 26/09/2014 14:26, Alexander Graf ha scritto:
> 
> Are you sure? Imagine one sysbus device includes another. We only want
> to look at the region the lowest sysbus device exposes, no?

IIUC this function is used to build the device tree.  Say you have 2
consecutive memory regions and the device tree requires separate "reg"
entries for them.  But because they are consecutive (or perhaps because
you have a PCI version of the same device that sticks them in a single
BAR) you use a single MMIO area at the sysbus level.

In that case, you will use platform_bus_get_mmio_addr on the two inner
regions, not the outer one.

BTW, I think you will never have one sysbus device including another.
The contained device would be busless (similar to the "naked" 8250
device in hw/char/serial.c, except perhaps QOMified).

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]