[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {} |
|
Date: |
Fri, 4 Dec 2015 06:22:24 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/03/2015 10:55 AM, Markus Armbruster wrote:
> I'm incapable of proof-reading anything I wrote myself %-}
I know the feeling :)
>
> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't
> visit anything. object_property_get_qobject() happily calls
> qmp_output_get_qobject() then. Amazingly, the latter survives the
> misuse. Turns out we've papered over it long before prop_get_fdt()
> existed, in commit 1d10b44.
Oh well, it got pushed to master with original confusing spelling after
all (commit ab8bf1d7). Not the end of the world :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-ppc] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}, David Gibson, 2015/12/03
[Qemu-ppc] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly, Markus Armbruster, 2015/12/03
[Qemu-ppc] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device, Markus Armbruster, 2015/12/03