[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 0/5] muldiv64() trivial fixes
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 0/5] muldiv64() trivial fixes |
Date: |
Mon, 9 May 2016 17:16:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
Gerd, I forgot to CC: you for the USB, audio patches,
Peter, for the OMAP one,
Alex, for the PPC one,
[Max Filippov has already acked the xtensa one, thanks!]
Thanks,
Laurent
On 09/05/2016 15:24, Laurent Vivier wrote:
> Some fixes in the use of muldiv64()
>
> The patches have been generated with the help of coccinelle.
>
> The first patch contains the scripts used to generate the two following
> patches. As it is done for linux, I've added the scripts under
> scripts/coccinelle.
>
> v2:
> - rework scripts/coccinelle/swap_muldiv64.cocci, to simplify it
> - add overflow_muldiv64.cocci and simplify_muldiv64.cocci
> - add resulting patches
>
> Laurent Vivier (5):
> scripts: add muldiv64() checking coccinelle scripts
> The only 64bit parameter of muldiv64() is the first one.
> remove useless muldiv64()
> replace muldiv64(a, b, c) by (uint64_t)a * b / c
> ppc: Remove a potential overflow in muldiv64()
>
> hw/audio/gus.c | 2 +-
> hw/ppc/ppc.c | 2 +-
> hw/timer/omap_gptimer.c | 4 ++--
> hw/usb/hcd-ohci.c | 2 +-
> hw/xtensa/pic_cpu.c | 4 ++--
> scripts/coccinelle/overflow_muldiv64.cocci | 16 ++++++++++++++++
> scripts/coccinelle/remove_muldiv64.cocci | 6 ++++++
> scripts/coccinelle/simplify_muldiv64.cocci | 11 +++++++++++
> scripts/coccinelle/swap_muldiv64.cocci | 13 +++++++++++++
> 9 files changed, 53 insertions(+), 7 deletions(-)
> create mode 100644 scripts/coccinelle/overflow_muldiv64.cocci
> create mode 100644 scripts/coccinelle/remove_muldiv64.cocci
> create mode 100644 scripts/coccinelle/simplify_muldiv64.cocci
> create mode 100644 scripts/coccinelle/swap_muldiv64.cocci
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 0/5] muldiv64() trivial fixes,
Laurent Vivier <=