[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] virtio: move bi-endian target support to a single
From: |
Greg Kurz |
Subject: |
Re: [Qemu-ppc] [PATCH] virtio: move bi-endian target support to a single location |
Date: |
Tue, 31 May 2016 16:10:04 +0200 |
On Tue, 31 May 2016 14:14:15 +0100
Peter Maydell <address@hidden> wrote:
> On 31 May 2016 at 14:10, Greg Kurz <address@hidden> wrote:
> > Hence my tentative to put all the details in one place... would it
> > be ok if I include "config-target.h" to ensure we have the TARGET macros ?
>
> No, config-target.h is one of the headers that should never be
> included by any file except osdep.h (and scripts/clean-includes
> will check for this). You're guaranteed that it's always included
> for you.
>
So we don't even need to include osdep.h in virtio-access.h because we
are sure all .c files that include virtio-access.h also include osdep.h
first. Correct ?
> thanks
> -- PMM
>