[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 8/9] ppc: Add missing slbfee. instruction on ppc64
|
From: |
Benjamin Herrenschmidt |
|
Subject: |
Re: [Qemu-ppc] [PATCH 8/9] ppc: Add missing slbfee. instruction on ppc64 BookS processors |
|
Date: |
Wed, 06 Jul 2016 08:10:09 +1000 |
On Tue, 2016-07-05 at 19:23 +0200, Cédric Le Goater wrote:
>
>
> So, I was trying today to reconciliate the powernv patchset with
> the current HEAD of qemu when I bumped into the old version of this
> patch. I checked the specs and when no slb are found, rt should
> just be 0. The machine check is only generated when multiple
> matching
> entries are found. So the above probably needs a fix, at least for
> the NULL case ?
Yes the old patch was broken but I wrote (and already merged) a better
one since then. Check upstream qemu :-)
The -1 result is now handled in the JITed code to do the right thing
(well, afaik).
Cheers,
Ben.