[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] spapr: Don't support query-hotpluggable-cpus on e
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-ppc] [PATCH] spapr: Don't support query-hotpluggable-cpus on earlier pseries machine types |
|
Date: |
Tue, 2 Aug 2016 10:34:34 +0530 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Aug 02, 2016 at 02:25:08PM +1000, David Gibson wrote:
> On Power, support for vCPU hotplug is new in qemu 2.7. However, we
> currently implement the query_hotpluggable_cpus hook the same for all
> pseries machine type versions.
>
> However, the old-style CPU initialization doesn't work with the new query
> code, meaning that attempting to use query-hotpluggable-cpus on a
> pseries-2.6 or earlier VM will cause qemu to SEGV.
>
> This fixes the problem by simply disabling the hook for earlier machine
> types.
I had sent a patch to fix this and a couple of other related issues
some time back and it indeed was accepted into your ppc-for-2.7 branch.
https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg01539.html
Only now I am realizing that somehow that patch didn't make it to mainline.
Regards,
Bharata.