Re: [Qemu-ppc] [PATCH 1/6] target-ppc: add xxspltib instruction

[Richard Henderson]

On 08/07/2016 11:06 PM, Nikunj A Dadhania wrote:
> +#define pattern(x) (((x) & 0xff) * (~(target_ulong)0 / 0xff))
> +
> +static void gen_xxspltib(DisasContext *ctx)
> +{
> +    unsigned char uim8 = IMM8(ctx->opcode);
> +    if (xS(ctx->opcode) < 32) {
> +        if (unlikely(!ctx->altivec_enabled)) {
> +            gen_exception(ctx, POWERPC_EXCP_VPU);
> +            return;
> +        }
> +    } else {
> +        if (unlikely(!ctx->vsx_enabled)) {
> +            gen_exception(ctx, POWERPC_EXCP_VSXU);
> +            return;
> +        }
> +    }
> +    tcg_gen_movi_i64(cpu_vsrh(xT(ctx->opcode)), pattern(uim8));
> +    tcg_gen_movi_i64(cpu_vsrl(xT(ctx->opcode)), pattern(uim8));
> +}
> +

Is this protected by TARGET_PPC64?  Otherwise the combination of movi_i64 and 
target_ulong looks odd.


r~