Re: [Qemu-ppc] [PATCH v1 02/10] target-ppc: consolidate load operations

[Nikunj A Dadhania]

Richard Henderson <address@hidden> writes:

> On 08/12/2016 05:52 AM, Nikunj A Dadhania wrote:
>> Richard Henderson <address@hidden> writes:
>>
>>> On 08/10/2016 08:00 PM, Nikunj A Dadhania wrote:
>>>> +#define GEN_QEMU_LOAD_64(ldop, op)                                  \
>>>> +static void glue(gen_qemu_, glue(ldop, _i64))(DisasContext *ctx,    \
>>>> +                                             TCGv_i64 val,          \
>>>> +                                             TCGv addr)             \
>>>> +{                                                                   \
>>>> +    tcg_gen_qemu_ld_i64(val, addr, ctx->mem_idx,                    \
>>>> +                        op | ctx->default_tcg_memop_mask);          \
>>>> +}
>>>> +
>>>> +GEN_QEMU_LOAD_64(ld32u, MO_UL)
>>>> +GEN_QEMU_LOAD_64(ld32s, MO_SL)
>>>>
>>>>  static inline void gen_qemu_ld64(DisasContext *ctx, TCGv_i64 arg1, TCGv 
>>>> arg2)
>>>>  {
>>>
>>> You can of course include this last function in the cleanup as well.
>>
>> Let me do this as separate patch, as it will need patching at lot of
>> places. This will be function name change: gen_qemu_ld64 =>
>> gen_qemu_ld64_i64
>
> Oh, right, of course.

I have done all these changes, will send to the list after testing.

Regards
Nikunj