[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU M
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion |
|
Date: |
Tue, 2 May 2017 11:30:23 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 29/04/2017 14:36, Alexey Kardashevskiy wrote:
>> Checking PATCH 1/1: memory/iommu: QOM'fy IOMMU MemoryRegion...
>> ERROR: spaces required around that '*' (ctx:WxO)
>> #156: FILE: hw/dma/rc4030.c:720:
>> +DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr)
>
> What does the script really want here? I am confused.
It's confused because rc4030_dma doesn't look like a type. It thinks
it's a multiplication and wants you to write "rc4030_dma * *dmas".
Paolo