[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH v1 1/6] migration: Fix unregister_savevm()
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-ppc] [RFC PATCH v1 1/6] migration: Fix unregister_savevm() |
|
Date: |
Wed, 17 May 2017 15:42:04 +0530 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, May 17, 2017 at 04:43:00PM +1000, David Gibson wrote:
> On Wed, May 17, 2017 at 09:19:17AM +0530, Bharata B Rao wrote:
> > In unregister_savevm(), free se->compat only if it was allocated earlier.
> >
> > Signed-off-by: Bharata B Rao <address@hidden>
>
> I don't think this is necessary. If se->compat was never allocated,
> then it should be NULL (since se is allocated with g_new0()).
> g_free() is explicitly safe to call on NULL, and we already rely on
> that in qemu.
Yeah, this is not necessary, will get rid of this in the next iteration.
Regards.,
Bharata.