[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] ppc: fix double-free in cpu_post_load()
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH] ppc: fix double-free in cpu_post_load() |
Date: |
Thu, 3 Aug 2017 11:37:23 +1000 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Aug 02, 2017 at 07:34:16PM +0200, Greg Kurz wrote:
> When running nested with KVM PR, ppc_set_compat() fails and QEMU crashes
> because of "double free or corruption (!prev)". The crash happens because
> error_report_err() has already called error_free().
>
> Signed-off-by: Greg Kurz <address@hidden>
Oops, that's a bit embarassing. Applied to ppc-for-2.10.
> ---
> target/ppc/machine.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/ppc/machine.c b/target/ppc/machine.c
> index f578156dd411..abe0a1cdf021 100644
> --- a/target/ppc/machine.c
> +++ b/target/ppc/machine.c
> @@ -239,7 +239,6 @@ static int cpu_post_load(void *opaque, int version_id)
> ppc_set_compat(cpu, cpu->compat_pvr, &local_err);
> if (local_err) {
> error_report_err(local_err);
> - error_free(local_err);
> return -1;
> }
> } else
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature