[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file |
Date: |
Mon, 14 Aug 2017 16:19:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 14/08/2017 13:18, BALATON Zoltan wrote:
> On Mon, 14 Aug 2017, Paolo Bonzini wrote:
>> On 13/08/2017 19:04, BALATON Zoltan wrote:
>>> Signed-off-by: BALATON Zoltan <address@hidden>
>>> ---
>>> hw/ppc/Makefile.objs | 2 +-
>>> hw/ppc/ppc405.h | 2 +
>>> hw/ppc/ppc405_uc.c | 241
>>> ---------------------------------------------
>>> hw/ppc/ppc4xx_i2c.c | 272
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>>> 4 files changed, 275 insertions(+), 242 deletions(-)
>>> create mode 100644 hw/ppc/ppc4xx_i2c.c
>>
>> Can you move it to hw/i2c while you're at it?
>
> I could if that's the preferred way but I've left it in hw/ppc because
> this is not a generic device but specific to PPC SoCs and it was easier
> to work with files in one dir than scattered through the tree. Should I
> still move it to hw/i2c?
Please do, having devices in hw/* helps when you do all-tree cleanups.
Paolo
[Qemu-ppc] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file, BALATON Zoltan, 2017/08/13
[Qemu-ppc] [RFC PATCH 07/12] ppc4xx_i2c: Implement basic I2C functions, BALATON Zoltan, 2017/08/13
[Qemu-ppc] [RFC PATCH 06/12] ppc4xx_i2c: QOMify, BALATON Zoltan, 2017/08/13
[Qemu-ppc] [RFC PATCH 01/12] ppc4xx: Move MAL from ppc405_uc to ppc4xx_devs, BALATON Zoltan, 2017/08/13
[Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board, BALATON Zoltan, 2017/08/13