[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI s
From: |
no-reply |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests |
Date: |
Fri, 18 Aug 2017 03:30:15 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in
QEMU for PowerKVM guests
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f473fc9b28 ppc: spapr: Enable FWNMI capability
11c89eaed9 target/ppc: Handle NMI guest exit
193cfab02d Wrapper function to wait on condition for the main loop mutex
b224364f6f ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS
calls
cb8ce5b786 ppc: spapr: Register and handle HCALL to receive updated RTAS region
=== OUTPUT BEGIN ===
Checking PATCH 1/5: ppc: spapr: Register and handle HCALL to receive updated
RTAS region...
Checking PATCH 2/5: ppc: spapr: Handle "ibm, nmi-register" and "ibm,
nmi-interlock" RTAS calls...
Checking PATCH 3/5: Wrapper function to wait on condition for the main loop
mutex...
Checking PATCH 4/5: target/ppc: Handle NMI guest exit...
Checking PATCH 5/5: ppc: spapr: Enable FWNMI capability...
ERROR: externs should be avoided in .c files
#24: FILE: hw/ppc/spapr_rtas.c:50:
+extern int cap_fwnmi;
total: 1 errors, 0 warnings, 44 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-ppc] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests, Aravinda Prasad, 2017/08/18
- [Qemu-ppc] [PATCH v4 1/5] ppc: spapr: Register and handle HCALL to receive updated RTAS region, Aravinda Prasad, 2017/08/18
- [Qemu-ppc] [PATCH v4 2/5] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls, Aravinda Prasad, 2017/08/18
- [Qemu-ppc] [PATCH v4 3/5] Wrapper function to wait on condition for the main loop mutex, Aravinda Prasad, 2017/08/18
- [Qemu-ppc] [PATCH v4 4/5] target/ppc: Handle NMI guest exit, Aravinda Prasad, 2017/08/18
- [Qemu-ppc] [PATCH v4 5/5] ppc: spapr: Enable FWNMI capability, Aravinda Prasad, 2017/08/18
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests, no-reply, 2017/08/18
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests,
no-reply <=
- Re: [Qemu-ppc] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests, David Gibson, 2017/08/18