[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-ke
From: |
no-reply |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node |
Date: |
Tue, 22 Aug 2017 00:17:03 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property
to CPU DT node
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
72241ec20e spapr: Add ibm, processor-storage-keys property to CPU DT node
=== OUTPUT BEGIN ===
Checking PATCH 1/1: spapr: Add ibm, processor-storage-keys property to CPU DT
node...
ERROR: braces {} are necessary for all arms of this statement
#59: FILE: hw/ppc/spapr.c:626:
+ if (!(env->mmu_model & POWERPC_MMU_AMR))
[...]
WARNING: line over 80 characters
#113: FILE: hw/ppc/spapr.c:680:
+ spapr->insn_keys = POWERPC_MMU_VER(env->mmu_model) !=
POWERPC_MMU_VER_2_06;
total: 1 errors, 1 warnings, 100 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-ppc] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node, Thiago Jung Bauermann, 2017/08/21
- Re: [Qemu-ppc] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node, David Gibson, 2017/08/21
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node,
no-reply <=
- Re: [Qemu-ppc] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node, Paul Mackerras, 2017/08/23
- Re: [Qemu-ppc] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node, Ram Pai, 2017/08/24
Re: [Qemu-ppc] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node, Ram Pai, 2017/08/28