[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented cpu models
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented cpu models |
Date: |
Thu, 31 Aug 2017 10:35:12 +0200 |
On Thu, 31 Aug 2017 09:58:45 +0200
Thomas Huth <address@hidden> wrote:
> On 30.08.2017 15:24, Igor Mammedov wrote:
> > Remove cpu models that aren't implemented and are not
> > compiled/tested since they are under TODO ifdef
> > which isn't defined in sources.
> >
> > If someone really needs a removed model he/she should add
> > as regular one with corresponding implementation.
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > target/ppc/cpu-models.c | 459
> > ------------------------------------------------
> > 1 file changed, 459 deletions(-)
> >
> > diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> > index cf878a9..611fc1b 100644
> > --- a/target/ppc/cpu-models.c
> > +++ b/target/ppc/cpu-models.c
> [...]
> > -#endif
> > #if defined(TODO_USER_ONLY)
> > POWERPC_DEF("440sp", CPU_POWERPC_440SP, 440EP,
> > "PowerPC 440 SP")
> > @@ -396,20 +207,6 @@
> > POWERPC_DEF("440spe", CPU_POWERPC_440SPE, 440EP,
> > "PowerPC 440 SPE")
> > #endif
> > - /* PowerPC 460 family
> > */
> > -#if defined(TODO)
> > - POWERPC_DEF("464", CPU_POWERPC_464, 460,
> > - "Generic PowerPC 464")
> > -#endif
> > - /* PowerPC 464 microcontrollers
> > */
> > -#if defined(TODO)
> > - POWERPC_DEF("464h90", CPU_POWERPC_464H90, 460,
> > - "PowerPC 464H90")
> > -#endif
> > -#if defined(TODO)
> > - POWERPC_DEF("464h90f", CPU_POWERPC_464H90F, 460F,
> > - "PowerPC 464H90F")
> > -#endif
>
> By the way, I guess you could also remove the 460 stuff from
> translate_init.c since there are no 460 CPUs defined in QEMU
> (but I guess that should go into a separate patch instead).
I would leave it to someone who knows more about PPC.
Would you like to post one?
- [Qemu-ppc] [PATCH v2 5/8] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups, (continued)
- [Qemu-ppc] [PATCH v2 5/8] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups, Igor Mammedov, 2017/08/30
- [Qemu-ppc] [PATCH v2 2/8] ppc: use macros to make cpu type name from string literal, Igor Mammedov, 2017/08/30
- [Qemu-ppc] [PATCH v2 1/8] ppc: replace cpu_ppc_init() with cpu_generic_init(), Igor Mammedov, 2017/08/30
- [Qemu-ppc] [PATCH v2 7/8] ppc: drop caching ObjectClass from PowerPCCPUAlias, Igor Mammedov, 2017/08/30
- [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented cpu models, Igor Mammedov, 2017/08/30
- [Qemu-ppc] [PATCH v2 3/8] ppc: make cpu_model translation to type consistent, Igor Mammedov, 2017/08/30