Re: [Qemu-ppc] [PATCH] sm501: Add missing break to case

[David Gibson]

On Thu, Jan 18, 2018 at 07:01:19PM +0100, BALATON Zoltan wrote:
> Noticed by Coverity, forgotten in 5690d9ece
> 
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: BALATON Zoltan <address@hidden>

Applied to ppc-for-2.12, thanks.

> ---
>  hw/display/sm501.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 4f7dc59b2..134cbed 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, 
> hwaddr addr,
>          break;
>      case SM501_COMMAND_LIST_STATUS:
>          ret = 0x00180002; /* FIFOs are empty, everything idle */
> +        break;
>      case SM501_IRQ_MASK:
>          ret = s->irq_mask;
>          break;

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature