Re: [Qemu-ppc] [PATCH 2/3] target/ppc: convert to DisasContextBase

[Richard Henderson]

On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> A couple of notes:
> 
> - removed ctx->nip in favour of base->pc_next. Yes, it is annoying,
>   but didn't want to waste its 4 bytes.
> 
> - ctx->singlestep_enabled does a lot more than
>   base.singlestep_enabled; this confused me at first.
> 
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  target/ppc/translate.c              | 129 
> +++++++++++++++++++-----------------
>  target/ppc/translate/dfp-impl.inc.c |  16 ++---
>  target/ppc/translate_init.c         |  32 ++++-----
>  3 files changed, 91 insertions(+), 86 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~