Re: [qemu-s390x] [PATCH v1 for-2.12 4/9] s390x/tcg: wire up SET CHANNEL MONITOR

[David Hildenbrand]

On 04.12.2017 18:32, Cornelia Huck wrote:
> On Mon, 4 Dec 2017 18:27:55 +0100
> David Hildenbrand <address@hidden> wrote:
> 
>> On 04.12.2017 18:24, Cornelia Huck wrote:
>>> On Mon,  4 Dec 2017 15:01:45 +0100
>>> David Hildenbrand <address@hidden> wrote:
>>>   
>>>> Let's just wire it up like KVM.
>>>>
>>>> Signed-off-by: David Hildenbrand <address@hidden>
>>>> ---
>>>>  target/s390x/helper.h      | 1 +
>>>>  target/s390x/insn-data.def | 1 +
>>>>  target/s390x/misc_helper.c | 9 +++++++++
>>>>  target/s390x/translate.c   | 7 +++++++
>>>>  4 files changed, 18 insertions(+)  
>>>
>>> So we would have generated an exception before if someone tried to
>>> enable channel measurements under tcg?
>>>   
>>
>> Yes, PGM_OPERATION should have been triggered.
>>
> 
> Next question: What happens now if we try to enable channel
> measurements? :)
> 

With my limited knowledge of the magical world of css, it seems to work.

address@hidden ~]# chccwdev --attribute cmb_enable=1 0.0.0001
Setting cmb_enable attribute of 0.0.0001 to 1
Done


-- 

Thanks,

David / dhildenb