[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory r
From: |
no-reply |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES |
Date: |
Mon, 11 Dec 2017 03:45:55 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the
old one exceeds KVM_MEM_MAX_NR_PAGES
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
28ebdee9e8 s390x: start a new memory region if the old one exceeds
KVM_MEM_MAX_NR_PAGES
=== OUTPUT BEGIN ===
Checking PATCH 1/1: s390x: start a new memory region if the old one exceeds
KVM_MEM_MAX_NR_PAGES...
ERROR: space prohibited before that close parenthesis ')'
#31: FILE: hw/s390x/s390-virtio-ccw.c:161:
+#define KVM_SLOT_MAX ((((1UL << 31) - 1) * 4096) & ~0xfffffUL )
ERROR: code indent should never use tabs
#58: FILE: hw/s390x/s390-virtio-ccw.c:185:
+^Inumber++;$
total: 2 errors, 0 warnings, 44 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden