Re: [qemu-s390x] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

[Cornelia Huck]

On Thu, 14 Dec 2017 14:26:17 +0100
David Hildenbrand <address@hidden> wrote:

> On 14.12.2017 14:21, Cornelia Huck wrote:
> > On Mon, 11 Dec 2017 13:21:46 +0100
> > Christian Borntraeger <address@hidden> wrote:
> >   
> >> KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically
> >> limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must
> >> be a multiple of 1MB we need start a new memory region if we cross
> >> 8TB-1M.
> >>
> >> With that (and optimistic overcommitment in the kernel) I was able to
> >> start a 24TB guest on a 1TB system.
> >>
> >> Signed-off-by: Christian Borntraeger <address@hidden>
> >> ---
> >>  hw/s390x/s390-virtio-ccw.c | 28 +++++++++++++++++++++++++---
> >>  1 file changed, 25 insertions(+), 3 deletions(-)  
> > 
> > Thanks, applied (with 1UL -> 1ULL).
> >   
> 
> Can you add my
> 
> Reviewed-by: David Hildenbrand <address@hidden>
> 
> ?
> 

Should be already in there :)