[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v3 1/8] s390-ccw: update libc
From: |
Christian Borntraeger |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v3 1/8] s390-ccw: update libc |
Date: |
Tue, 16 Jan 2018 12:07:18 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 01/15/2018 06:23 PM, Collin L. Walling wrote:
> On 01/15/2018 12:05 PM, Eric Blake wrote:
>> On 01/15/2018 10:44 AM, Collin L. Walling wrote:
>>> Moved:
>>> memcmp from bootmap.h to libc.h (renamed from _memcmp)
>>> strlen from sclp.c to libc.h (renamed from _strlen)
>>>
>>> Added C standard functions:
>>> isdigit
>>> atoi
>>>
>>> Added non-C standard function:
>>> itostr
>>>
>>> Signed-off-by: Collin L. Walling <address@hidden>
>>> Acked-by: Christian Borntraeger <address@hidden>
>>> Reviewed-by: Janosch Frank <address@hidden>
>>> ---
>>> +++ b/pc-bios/s390-ccw/libc.c
>>> @@ -0,0 +1,83 @@
>>> +/*
>>> + * libc-style definitions and functions
>>> + *
>>> + * This code is free software; you can redistribute it and/or modify it
>>> + * under the terms of the GNU General Public License as published by the
>>> + * Free Software Foundation; either version 2 of the License, or (at your
>>> + * option) any later version.
>> I'm not a lawyer, but generically, the GPL and its variants depend on a
>> copyright owner to actually work. You may want to add a copyright line.
>
>
> I'll have to check on that. I was not the original author of the libc.h file.
I think you can add the normal IBM Copyright statement. (I think all authors
could add theirs as well)
[qemu-s390x] [PATCH v3 3/8] s390-ccw: parse and set boot menu options, Collin L. Walling, 2018/01/15
[qemu-s390x] [PATCH v3 2/8] s390-ccw: ipl structs for eckd cdl/ldl, Collin L. Walling, 2018/01/15
[qemu-s390x] [PATCH v3 4/8] s390-ccw: interactive boot menu for eckd dasd (menu setup), Collin L. Walling, 2018/01/15