[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 26/29] s390x/pci: use the right pal and pba in reg_io
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 26/29] s390x/pci: use the right pal and pba in reg_ioat() |
Date: |
Fri, 9 Feb 2018 10:25:21 +0100 |
From: Yi Min Zhao <address@hidden>
When registering ioat, pba should be comprised of leftmost 52 bits and
rightmost 12 binary zeros, and pal should be comprised of leftmost 52
bits and right most 12 binary ones. The lower 12 bits of words 5 and 7
of the FIB are ignored by the facility. Let's fixup this.
Reviewed-by: Pierre Morel <address@hidden>
Signed-off-by: Yi Min Zhao <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/s390-pci-inst.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index 997a9cc2e9..3fcc330fe3 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -865,6 +865,8 @@ static int reg_ioat(CPUS390XState *env, S390PCIIOMMU
*iommu, ZpciFib fib,
uint8_t dt = (g_iota >> 2) & 0x7;
uint8_t t = (g_iota >> 11) & 0x1;
+ pba &= ~0xfff;
+ pal |= 0xfff;
if (pba > pal || pba < ZPCI_SDMA_ADDR || pal > ZPCI_EDMA_ADDR) {
s390_program_interrupt(env, PGM_OPERAND, 6, ra);
return -EINVAL;
--
2.13.6
- [qemu-s390x] [PULL 17/29] s390x/tcg: cache the qemu flic in a central function, (continued)
- [qemu-s390x] [PULL 17/29] s390x/tcg: cache the qemu flic in a central function, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 16/29] configure: s390x supports mttcg now, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 15/29] s390x/tcg: remove SMP warning, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 20/29] s390x/sclp: fix event mask handling, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 21/29] s390x/tcg: wire up pci instructions, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 22/29] s390x/cpumodel: allow zpci features in qemu model, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 23/29] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 24/29] s390x/pci: fixup the code walking IOMMU tables, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 19/29] s390x/flic: cache the common flic class in a central function, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 25/29] s390x/pci: fixup global refresh, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 26/29] s390x/pci: use the right pal and pba in reg_ioat(),
Cornelia Huck <=
- [qemu-s390x] [PULL 27/29] MAINTAINERS: add myself as overall s390x maintainer, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 29/29] MAINTAINERS: add David as additional tcg/s390 maintainer, Cornelia Huck, 2018/02/09
- [qemu-s390x] [PULL 28/29] MAINTAINERS: reorganize s390-ccw bios maintainership, Cornelia Huck, 2018/02/09
- Re: [qemu-s390x] [Qemu-devel] [PULL 00/29] s390x: assorted updates, no-reply, 2018/02/09
- Re: [qemu-s390x] [PULL 00/29] s390x: assorted updates, Peter Maydell, 2018/02/09