[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS de
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define |
|
Date: |
Fri, 23 Feb 2018 11:02:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/23/2018 10:54 AM, Cornelia Huck wrote:
> It's already defined in cpu.h (to the same value) and not used in
> the sclp code.
>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> include/hw/s390x/sclp.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> index 476cbf78f2..f9db243484 100644
> --- a/include/hw/s390x/sclp.h
> +++ b/include/hw/s390x/sclp.h
> @@ -35,7 +35,6 @@
> #define SCLP_FC_ASSIGN_ATTACH_READ_STOR 0xE00000000000ULL
> #define SCLP_STARTING_SUBINCREMENT_ID 0x10001
> #define SCLP_INCREMENT_UNIT 0x10000
> -#define MAX_AVAIL_SLOTS 32
> #define MAX_STORAGE_INCREMENTS 1020
>
> /* CPU hotplug SCLP codes */
>
Do we need this define and s390_get_memslot_count at all after removing
the hotplug code?