[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH 3/7] target/s390x: fix CSST decoding and runtime
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH 3/7] target/s390x: fix CSST decoding and runtime alignment check |
Date: |
Fri, 10 Aug 2018 15:07:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 10.08.2018 05:01, Pavel Zbitskiy wrote:
> CSST is defined as:
>
> C(0xc802, CSST, SSF, CASS, la1, a2, 0, 0, csst, 0)
>
> It means that the first parameter is handled by in1_la1().
> in1_la1() fills addr1 field, and not in1.
>
> Furthermore, when extract32() is used for the alignment check, the
> third parameter should specify the number of trailing bits that must
> be 0. For FC these numbers are:
>
> FC=0 (word, 4 bytes): 2
> FC=1 (double word, 8 bytes): 3
> FC=2 (quad word, 16 bytes): 4
>
> For SC these numbers correspond to the size:
>
> SC=0: 0
> SC=1: 1
> SC=2: 2
> SC=3: 3
> SC=4: 4
>
> Signed-off-by: Pavel Zbitskiy <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David / dhildenb
- [qemu-s390x] [PATCH 0/7] Some improvements in z/Arch instructions support, Pavel Zbitskiy, 2018/08/09
- [qemu-s390x] [PATCH 1/7] tests/tcg: add a simple s390x test, Pavel Zbitskiy, 2018/08/09
- [qemu-s390x] [PATCH 2/7] target/s390x: add BAL and BALR instructions, Pavel Zbitskiy, 2018/08/09
- [qemu-s390x] [PATCH 3/7] target/s390x: fix CSST decoding and runtime alignment check, Pavel Zbitskiy, 2018/08/09
- Re: [qemu-s390x] [PATCH 3/7] target/s390x: fix CSST decoding and runtime alignment check,
David Hildenbrand <=
- [qemu-s390x] [PATCH 4/7] target/s390x: fix IPM polluting irrelevant bits, Pavel Zbitskiy, 2018/08/09
- [qemu-s390x] [PATCH 5/7] target/s390x: add EX support for TRT and TRTR, Pavel Zbitskiy, 2018/08/09
- [qemu-s390x] [PATCH 6/7] target/s390x: fix PACK reading 1 byte less and writing 1 byte more, Pavel Zbitskiy, 2018/08/09
- [qemu-s390x] [PATCH 7/7] target/s390x: implement CVB, CVBY and CVBG, Pavel Zbitskiy, 2018/08/09
- Re: [qemu-s390x] [PATCH 0/7] Some improvements in z/Arch instructions support, Cornelia Huck, 2018/08/10
- Re: [qemu-s390x] [PATCH 0/7] Some improvements in z/Arch instructions support, David Hildenbrand, 2018/08/10
- Re: [qemu-s390x] [Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions support, no-reply, 2018/08/15