[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinit
From: |
Peter Maydell |
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity |
Date: |
Wed, 20 Feb 2013 14:49:11 +0000 |
On 20 February 2013 14:43, Laszlo Ersek <address@hidden> wrote:
> On 02/20/13 14:43, Paolo Bonzini wrote:
>> QEMU system emulation has been thread-safe for a long time
Says who? cpu_interrupt() calls tcg_handle_interrupt()
which calls cpu_unlink_tb() which makes changes to the
TB datastructure with no kind of locking at all.
I'm actually working on a patchset which fixes this
(by having every TCG TB check the exit_request flag at
the start and exit if set, so we can throw out cpu_unlink_tb()
entirely), but as of right now the codebase is definitely
not threadsafe.
-- PMM