[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] 9p: Be robust against paths without FS_IOC_GET
From: |
Aneesh Kumar K.V |
Subject: |
Re: [Qemu-stable] [PATCH] 9p: Be robust against paths without FS_IOC_GETVERSION |
Date: |
Fri, 10 May 2013 09:00:32 +0530 |
User-agent: |
Notmuch/0.15.2+52~gb714a80 (http://notmuchmail.org) Emacs/24.3.50.1 (x86_64-unknown-linux-gnu) |
Gabriel de Perthuis <address@hidden> writes:
> The current implementation checked for supported filesystems at mount
> time, but actual support depends on the path. Don't error out when
> finding unversioned paths.
Can you elaborate this a bit ?
>
> This fix allows booting a linux kernel with the same / filesystem as the
> host; otherwise the boot fails when mounting devtmpfs.
>
> Signed-off-by: Gabriel de Perthuis <address@hidden>
> ---
> hw/9pfs/cofile.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/9pfs/cofile.c b/hw/9pfs/cofile.c
> index 2efebf3..194c130 100644
> --- a/hw/9pfs/cofile.c
> +++ b/hw/9pfs/cofile.c
> @@ -36,10 +36,14 @@ int v9fs_co_st_gen(V9fsPDU *pdu, V9fsPath *path, mode_t
> st_mode,
> err = -errno;
> }
> });
> v9fs_path_unlock(s);
> }
> + /* The ioctl may not be supported depending on the path */
> + if (err == -ENOTTY) {
> + err = 0;
> + }
So you don't want to consider -ENOTTY as an error ? why ?
> return err;
> }
>
> int v9fs_co_lstat(V9fsPDU *pdu, V9fsPath *path, struct stat *stbuf)
> {
> --
-aneesh