Re: [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI

[Brad Smith]

On Thu, May 23, 2013 at 07:06:57PM +0400, Michael Tokarev wrote:
> 23.05.2013 02:38, Brad Smith wrote:
> > Fix the build of the Gtk+ UI on *BSD systems.
> > 
> > Signed-off-by: Brad Smith <address@hidden>
> > Reviewed-by: Laszlo Ersek <address@hidden>
> > Message-id: address@hidden
> > Signed-off-by: Anthony Liguori <address@hidden>
> > 
> > diff --git a/include/qemu-common.h b/include/qemu-common.h
> > index af769f5..c944bb7 100644
> > --- a/include/qemu-common.h
> > +++ b/include/qemu-common.h
> > @@ -45,6 +45,7 @@
> >  #if defined(__GLIBC__)
> >  # include <pty.h>
> >  #elif defined CONFIG_BSD
> > +# include <termios.h>
> >  # if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || 
> > defined(__DragonFly__)
> >  #  include <libutil.h>
> >  # else
> > 
> 
> Do we really need to have all this in a common header file?
> Together with termios, libutil, pty and other unrelated stuff?
> 
> Oh well..

Kinda late nit picking about it now.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.