[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory le
From: |
Benoît Canet |
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency() |
Date: |
Tue, 27 May 2014 13:00:03 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Monday 26 May 2014 à 19:37:12 (+0200), Markus Armbruster wrote :
> On error path. Introduced in commit a046433a. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/vvfat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 6a0d246..2c82a5c 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1864,7 +1864,7 @@ static int check_directory_consistency(BDRVVVFATState
> *s,
>
> if (s->used_clusters[cluster_num] & USED_ANY) {
> fprintf(stderr, "cluster %d used more than once\n",
> (int)cluster_num);
> - return 0;
> + goto fail;
Hmm your editor display tabs at 8 chars so you put 12 chars of alignement.
Anyway the patch seems correct.
Reviewed-by: Benoit Canet <address@hidden>
> }
> s->used_clusters[cluster_num] = USED_DIRECTORY;
>
> --
> 1.9.3
>
>
- Re: [Qemu-stable] [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, (continued)
- [Qemu-stable] [PATCH 08/14] blockdev: Plug memory leak in blockdev_init(), Markus Armbruster, 2014/05/26
- [Qemu-stable] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Markus Armbruster, 2014/05/26
- [Qemu-stable] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/26
- [Qemu-stable] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster, 2014/05/26
- [Qemu-stable] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path, Markus Armbruster, 2014/05/26
- [Qemu-stable] [PATCH 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths, Markus Armbruster, 2014/05/26
- [Qemu-stable] [PATCH 05/14] qemu-io: Support multiple -o in open command, Markus Armbruster, 2014/05/26