[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak
From: |
Konrad Rzeszutek Wilk |
Subject: |
Re: [Qemu-stable] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak |
Date: |
Thu, 27 Nov 2014 09:53:10 -0500 |
On Nov 27, 2014 7:46 AM, Stefano Stabellini <address@hidden> wrote:
>
> Konrad, I think we should have this fix in 4.5: without it
> vif=[ 'model=virtio-net' ] crashes QEMU.
>
Is it an regression?
>
> On Thu, 27 Nov 2014, Peter Maydell wrote:
> > On 27 November 2014 at 12:33, Michael S. Tsirkin <address@hidden> wrote:
> > > On Thu, Nov 27, 2014 at 06:04:03PM +0800, Jason Wang wrote:
> > >> virtio_net_handle_ctrl() and other functions that process control vq
> > >> request call iov_discard_front() which will shorten the iov. This will
> > >> lead unmapping in virtqueue_push() leaks mapping.
> > >>
> > >> Fixes this by keeping the original iov untouched and using a temp
> > >> variable
> > >> in those functions.
> > >>
> > >> Cc: Wen Congyang <address@hidden>
> > >> Cc: Stefano Stabellini <address@hidden>
> > >> Cc: address@hidden
> > >> Signed-off-by: Jason Wang <address@hidden>
> > >
> > > Reviewed-by: Michael S. Tsirkin <address@hidden>
> > >
> > > Peter, can you pick this up or do you want a pull request?
> >
> > I can pick it up. I was waiting a bit to check that everybody
> > was happy that this is the correct way to fix the bug and the
> > patch is ok...
- Re: [Qemu-stable] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak,
Konrad Rzeszutek Wilk <=