Re: [Qemu-stable] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts

[Eduardo Habkost]

On Tue, Jan 13, 2015 at 08:49:19PM +0100, Paolo Bonzini wrote:
> 
> 
> On 13/01/2015 19:48, Eduardo Habkost wrote:
> >> >              if (b1 & 1) {
> >> > -                gen_stq_env_A0(s, offsetof(CPUX86State, xmm_regs[reg]));
> >> > +                gen_stq_env_A0(s, offsetof(CPUX86State,
> >> > +                                           xmm_regs[reg].XMM_Q(0)));
> > Do we have (or will patch 4/4 introduce) the same bug on the
> > tcg_gen_addi_ptr() calls that don't use the XMM_Q macro?
> 
> No, they all call into helpers that use the XMM_Q macro themselves.

tcg_gen_addi_ptr() is called sometimes using the fpregs[reg].mmx offset,
and sometimes using the xmm_regs[reg] offset. How can it know if the
XMM_Q macro is necessary or not?

-- 
Eduardo