[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-stable] [PULL 01/12] vt82c686: avoid out-of-bounds read
From: |
Michael Tokarev |
Subject: |
[Qemu-stable] [PULL 01/12] vt82c686: avoid out-of-bounds read |
Date: |
Thu, 15 Jan 2015 11:30:39 +0300 |
From: Paolo Bonzini <address@hidden>
superio_ioport_readb can read the 256th element of the array.
Coverity reports an out-of-bounds write in superio_ioport_writeb,
but it does not show the corresponding out-of-bounds read
because it cannot prove that it can happen. Fix the root
cause of the problem (zhanghailang's patch instead fixes
the logic in superio_ioport_writeb).
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
Cc: address@hidden
---
hw/isa/vt82c686.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index 223b947..2f53bf8 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -36,7 +36,7 @@
typedef struct SuperIOConfig
{
- uint8_t config[0xff];
+ uint8_t config[0x100];
uint8_t index;
uint8_t data;
} SuperIOConfig;
--
2.1.4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-stable] [PULL 01/12] vt82c686: avoid out-of-bounds read,
Michael Tokarev <=