[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH v3 2/2] tests: update expected SSD
From: |
Roman Kagan |
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes |
Date: |
Fri, 25 Dec 2015 18:25:17 +0300 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Dec 24, 2015 at 08:17:45AM +0200, Michael S. Tsirkin wrote:
> On Wed, Dec 23, 2015 at 08:51:45PM +0300, Roman Kagan wrote:
> > On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote:
> > > On Wed, 23 Dec 2015 20:20:54 +0300
> > > Roman Kagan <address@hidden> wrote:
> > > > > ... two 1.44M drives with bogus geometry for q35.
> > > >
> > > > This one is a bug in my patch, indeed: I was tricked by FDRIVE_DRV_NONE
> > > > being non-zero, and forgot to initialize the respective fields in
> > > > acpi_get_misc_info() in case there is no floppy controller at all.
> > > so instead of fake initialization, it's worth to make your patch
> > > conditional on presence of controller after all.
> > > i.e. add AML only if controller was present.
> >
> > Indeed :)
> >
> > Roman.
>
> Or rather, start series with a patch making FDC conditional,
> then update expected ssdt, then tweak methods within -
> should not change ssdt since we don't create a floppy in
> the test.
Actually we do. "pc" machine type has it by default regardless of
whether anything is attached to it.
So I ended up with the patch series v4 I just posted but I'm not sure it
addresses all the concerns people have had about v3.
Thanks,
Roman.
- [Qemu-stable] [PATCH v3 0/2] i386: expose floppy-related objects in SSDT, (continued)
- [Qemu-stable] [PATCH v3 0/2] i386: expose floppy-related objects in SSDT, Roman Kagan, 2015/12/18
- [Qemu-stable] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Roman Kagan, 2015/12/18
- Re: [Qemu-stable] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Michael S. Tsirkin, 2015/12/22
- Re: [Qemu-stable] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Roman Kagan, 2015/12/23
- Re: [Qemu-stable] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Michael S. Tsirkin, 2015/12/23
- Re: [Qemu-stable] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Roman Kagan, 2015/12/23
- Re: [Qemu-stable] [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Roman Kagan, 2015/12/23
- Re: [Qemu-stable] [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Igor Mammedov, 2015/12/23
- Re: [Qemu-stable] [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Roman Kagan, 2015/12/23
- Re: [Qemu-stable] [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes, Michael S. Tsirkin, 2015/12/24
- Re: [Qemu-stable] [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes,
Roman Kagan <=
[Qemu-stable] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT, Roman Kagan, 2015/12/18
Re: [Qemu-stable] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT, Igor Mammedov, 2015/12/22