[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-relate
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT |
Date: |
Tue, 29 Dec 2015 15:09:36 +0100 |
On Fri, 25 Dec 2015 18:04:08 +0300
Roman Kagan <address@hidden> wrote:
> Windows on UEFI systems is only capable of detecting the presence and
> the type of floppy drives via corresponding ACPI objects.
>
> Those objects are added in the last patch of the series; the three
> preceding ones pave the way to it, by making the necessary data
> public and by moving the whole floppy drive controller description into
> runtime-generated SSDT.
>
> Note that the series conflicts with Igor's patchset for dynamic DSDT, in
> particular, with "[PATCH 50/74] pc: acpi: move FDC0 device from DSDT
> to SSDT"; I haven't managed to avoid that while trying to meet
> maintainer's comments.
To remove conflicts and to make it more suitable for stable, I'd drop
"2/4 i386/acpi: make floppy controller object dynamic"
and split test blob out of
"4/4 i386: populate floppy drive information in SSDT"
into a separate patch so one can see effects of applying 4/4
and then update blobs if resulting ASL diff is as expected.
>
> Roman Kagan (4):
> i386/pc: expose identifying the floppy controller
> i386/acpi: make floppy controller object dynamic
> expose floppy drive geometry and CMOS type
> i386: populate floppy drive information in SSDT
>
> Signed-off-by: Roman Kagan <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: John Snow <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> ---
> changes since v3:
> - make FDC object fully dynamic in a separate patch
> - split out support patches
> - include test data updates with the respective patches to maintain
> bisectability
>
> changes since v2:
> - explicit endianness for buffer data
> - reorder code to reduce conflicts with dynamic DSDT patchset
> - update test data
>
>
> hw/block/fdc.c | 11 +++++
> hw/i386/acpi-build.c | 92
> ++++++++++++++++++++++++++++++++++++
> hw/i386/acpi-dsdt-isa.dsl | 18 -------
> hw/i386/acpi-dsdt.dsl | 1 -
> hw/i386/pc.c | 46 ++++++++++--------
> hw/i386/q35-acpi-dsdt.dsl | 7 +--
> include/hw/block/fdc.h | 2 +
> include/hw/i386/pc.h | 3 ++
> tests/acpi-test-data/pc/DSDT | Bin 3028 -> 2946 bytes
> tests/acpi-test-data/pc/SSDT | Bin 2486 -> 2635 bytes
> tests/acpi-test-data/pc/SSDT.bridge | Bin 4345 -> 4494 bytes
> tests/acpi-test-data/q35/DSDT | Bin 7666 -> 7578 bytes
> 12 files changed, 137 insertions(+), 43 deletions(-)
>