[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [RESEND PATCH 1/1] ide: fix halted IO segfault at rese
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-stable] [RESEND PATCH 1/1] ide: fix halted IO segfault at reset |
Date: |
Wed, 27 Jul 2016 17:21:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 07/27/16 16:51, John Snow wrote:
> If one attempts to perform a system_reset after a failed IO request
> that causes the VM to enter a paused state, QEMU will segfault trying
> to free up the pending IO requests.
>
> These requests have already been completed and freed, though, so all
> we need to do is NULL them before we enter the paused state.
>
> Existing AHCI tests verify that halted requests are still resumed
> successfully after a STOP event.
>
> Analyzed-by: Laszlo Ersek <address@hidden>
> ---
> hw/ide/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index 081c9eb..d117b7c 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -823,6 +823,7 @@ static void ide_dma_cb(void *opaque, int ret)
> }
> if (ret < 0) {
> if (ide_handle_rw_error(s, -ret, ide_dma_cmd_to_retry(s->dma_cmd))) {
> + s->bus->dma->aiocb = NULL;
> return;
> }
> }
>
You forgot your S-o-b from the end of the commit message, and also my
R-b from round #1. Looks like my un-orthodox Analyzed-by distracted you
too much! ;)
Care to resend once more with those two tags added?
Thanks!
Laszlo