|
From: | Bruce Rogers |
Subject: | Re: [Qemu-stable] [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin |
Date: | Mon, 01 Aug 2016 11:17:14 -0600 |
Hi Cao, Upon re-reading your comment, I believe you are still thinking that it was right to use the error object in this context. The fact that this device has no pin interrupt is _not_ an error condition, and hence the use of error_setg() is not appropriate, and in fact causes Xen HVM PCI passthrough to fail, when it would otherwise succeed. This patch does not attempt to address any shortcomings with XEN_PT_LOG, since it is still in use in many other places in this source file. hth, Bruce
>>> Cao jin <address@hidden> 7/27/2016 9:10 PM >>> |
[Prev in Thread] | Current Thread | [Next in Thread] |