Re: [Qemu-stable] [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field

[Stefan Hajnoczi]

On Tue, Aug 23, 2016 at 08:49:35AM +0200, Peter Lieven wrote:
> Am 17.08.2016 um 15:58 schrieb Stefan Hajnoczi:
> > On Mon, Aug 15, 2016 at 01:54:14PM +0100, Stefan Hajnoczi wrote:
> > > The VirtQueue->inuse field is not always updated correctly.  These 
> > > patches fix
> > > it.
> > > 
> > > Originally this series was called "virtio-balloon: fix stats vq 
> > > migration" but
> > > Ladi Prosek posted a nicer fix called "balloon: Fix failure of updating 
> > > guest
> > > memory status".  I dropped the virtio-balloon patches.
> > > 
> > > Changes from previous series:
> > >   * Missing comma in error formatting [Fam]
> > >   * virtio_descard() -> virtio_discard() [Michael]
> > >   * Multi-line comment style [Cornelia]
> > > 
> > > Stefan Hajnoczi (2):
> > >    virtio: recalculate vq->inuse after migration
> > >    virtio: decrement vq->inuse in virtqueue_discard()
> > > 
> > >   hw/virtio/virtio.c | 16 ++++++++++++++++
> > >   1 file changed, 16 insertions(+)
> > I should mention this is for QEMU 2.7.  These fixes are needed if the
> > CVE-2016-5403 patch has been applied.
> > 
> > Without these patches any device that holds VirtQueueElements across
> > live migration will terminate with a "Virtqueue size exceeded" error
> > message.  virtio-balloon and virtio-scsi are affected.  virtio-blk
> > probably too but I haven't tested it.
> > 
> > Stefan
> 
> I noticed that these patches are not in master yet and therefore
> not included in the 2.7.0-rc4 tagges yesterday. Is there any issue with them?

I think Michael Tsirkin is offline.  This series is waiting on him to
merge.

Stefan

signature.asc
Description: PGP signature