[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] qcow2: fix encryption during cow of sectors
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-stable] [PATCH] qcow2: fix encryption during cow of sectors |
Date: |
Tue, 6 Sep 2016 16:40:40 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 06.09.2016 um 16:26 hat Daniel P. Berrange geschrieben:
> Broken in previous commit:
>
> commit aaa4d20b4972bb1a811ce929502e6741835d584e
> Author: Kevin Wolf <address@hidden>
> Date: Wed Jun 1 15:21:05 2016 +0200
>
> qcow2: Make copy_sectors() byte based
>
> The copy_sectors() code was originally using the 'sector'
> parameter for encryption, which was passed in by the caller
> from the QCowL2Meta.offset field (aka the guest logical
> offset).
>
> After the change, the code is using 'cluster_offset' which
> was passed in from QCow2L2Meta.alloc_offset field (aka the
> host physical offset).
>
> This would cause the data to be encrypted using an incorrect
> initialization vector which will in turn cause later reads
> to return garbage.
>
> Although current qcow2 built-in encryption is blocked from
> usage in the emulator, one could still hit this if writing
> to the file via qemu-{img,io,nbd} commands.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Cc: address@hidden
Oops, thanks. Applied to the block branch.
Kevin
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-stable] [PATCH] qcow2: fix encryption during cow of sectors,
Kevin Wolf <=