Re: [Qemu-stable] [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Since commit ad739706bbadee49, user_creatable_add_type() expects to be
> given a qdict. However, if object-add is called without props, you reach
> the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type:
> Assertion `qdict' failed.", because the qdict isn't created in this
> case (it's optional).
>
> Furthermore, qmp_input_visitor_new() is not meant to be called without a
> dict, and a further commit will assert in this situation.
>
> If none given, create an empty qdict in qmp to avoid the
> user_creatable_add_type() assert(qdict).
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>