qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-stable] [PATCH 1/3] migrate: Fix cpu-throttle-increment regres


From: Juan Quintela
Subject: Re: [Qemu-stable] [PATCH 1/3] migrate: Fix cpu-throttle-increment regression in HMP
Date: Wed, 05 Oct 2016 11:12:23 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Eric Blake <address@hidden> wrote:
> Commit 69ef1f3 accidentally broke migrate_set_parameter's ability
> to set the cpu-throttle-increment to anything other than the
> default, because it forgot to parse the user's string into an
> integer.
>
> CC: address@hidden
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  hmp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hmp.c b/hmp.c
> index ad33b44..d6c6c01 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1286,6 +1286,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const 
> QDict *qdict)
>                  break;
>              case MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT:
>                  has_cpu_throttle_increment = true;
> +                use_int_value = true;
>                  break;
>              case MIGRATION_PARAMETER_TLS_CREDS:
>                  has_tls_creds = true;

Reviewed-by: Juan Quintela <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]