Re: [Qemu-stable] [Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images

[Peter Maydell]

On 23 February 2018 at 18:53, Mark Cave-Ayland
<address@hidden> wrote:
> On 23/02/18 18:04, Peter Maydell wrote:
>
>> On 23 February 2018 at 11:29, Mark Cave-Ayland
>> <address@hidden> wrote:
>>>
>>> All memory region ROM images have a base address of 0 which causes the
>>> overlapping
>>> address check to fail if more than one memory region ROM image is
>>> present, or an
>>> existing ROM image is loaded at address 0.
>>>
>>> Make sure that we ignore the overlapping address check in
>>> rom_check_and_register_reset() if this is a memory region ROM image. In
>>> particular
>>> this fixes the "rom: requested regions overlap" error on startup when
>>> trying to
>>> run qemu-system-sparc with a -kernel image since commit 7497638642: "tcx:
>>> switch to
>>> load_image_mr() and remove prom_addr hack".
>>>
>>> Suggested-by: Peter Maydell <address@hidden>
>>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>>
>>
>> Reviewed-by: Peter Maydell <address@hidden>
>>
>> Do you want to take this via your sparc tree?
>
>
> I can do, although I don't have any outstanding SPARC patches (just PPC ones
> for the moment) so it would just be a single commit PR. Is that okay?

Yeah, it's less effort for me to apply a pull than a patch in some
ways...

thanks
-- PMM