[Qemu-stable] qmp unix socket is not deleted at instance shutdown

[Pavel Balaev]

Hello all. 

After upgrade QEMU from 2.11.0 to 2.12.0 qmp unix socket file is not
deleted on instance shutdown.

This is due to the fact that function qio_channel_socket_finalize() is
called after qio_channel_socket_close().

Function qio_channel_socket_close() close the socket and set fd to -1.
After that qio_channel_socket_finalize() do not call
socket_listen_cleanup() (it calls unlink on AF_UNIX socket path).

I write dirty patch to avoid this:

--- qemu-2.12.0.orig/io/net-listener.c  2018-05-18 10:30:35.179008687 +0300
+++ qemu-2.12.0/io/net-listener.c       2018-05-18 15:43:30.939903985 +0300
@@ -278,7 +278,7 @@
             g_source_unref(listener->io_source[i]);
             listener->io_source[i] = NULL;
         }
-        qio_channel_close(QIO_CHANNEL(listener->sioc[i]), NULL);
+        //qio_channel_close(QIO_CHANNEL(listener->sioc[i]), NULL);
     }
     listener->connected = false;
 }

But this is not good solution.