[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] x86: fix daa opcode for al regis
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] x86: fix daa opcode for al register values higher than 0xf9 |
Date: |
Tue, 30 Aug 2011 12:18:35 +0100 |
On 30 August 2011 08:00, Boris Figovsky
<address@hidden> wrote:
> The second if statement should consider the original al register value,
> and not the new one.
Reviewed-by: Peter Maydell <address@hidden>
(It took me some time to convince myself that the line
CF <- old_CF or (Carry from AL <- AL + 6)
in the Intel architecture manual is actually redundant; the
AMD docs are much clearer here...)
-- PMM