[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [RESEND PATCH 1/3] socket: remove redundant check
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [RESEND PATCH 1/3] socket: remove redundant check |
Date: |
Wed, 1 Aug 2012 11:50:11 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Aug 01, 2012 at 04:59:01PM +0800, Amos Kong wrote:
> It's aleady in the end of loop, error should be set.
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> qemu-sockets.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-sockets.c b/qemu-sockets.c
> index 668fa93..c636882 100644
> --- a/qemu-sockets.c
> +++ b/qemu-sockets.c
> @@ -181,9 +181,7 @@ int inet_listen_opts(QemuOpts *opts, int port_offset,
> Error **errp)
> fprintf(stderr,"%s: bind(%s,%s,%d): %s\n", __FUNCTION__,
> inet_strfamily(e->ai_family), uaddr, inet_getport(e),
> strerror(errno));
> - if (!e->ai_next) {
> - error_set(errp, QERR_SOCKET_BIND_FAILED);
> - }
> + error_set(errp, QERR_SOCKET_BIND_FAILED);
> }
> }
> closesocket(slisten);
This isn't obvious. It looks like the intent of the if (!e->ai_next) is
to suppress the error so that the next iteration of the *outer* loop can
succeed.
Why is it okay to set QERR_SOCKET_BIND_FAILED? We may have more
addrinfos left to try in the outer loop. They may succeed so we don't
want an error in that case.
Stefan
Message not available
Message not available