[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] device_tree: load_device_tree():
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep |
Date: |
Fri, 10 Aug 2012 14:42:45 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Aug 10, 2012 at 01:54:26PM +1000, Peter A. G. Crosthwaite wrote:
> The sizep arg is populated with the size of the loaded device tree. Since this
> is one of those informational "please populate" type arguments it should be
> optional. Guarded writes to *sizep against NULL accordingly.
>
> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
> Acked-by: Alexander Graf <address@hidden>
> ---
> device_tree.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/device_tree.c b/device_tree.c
> index d7a9b6b..641a48a 100644
> --- a/device_tree.c
> +++ b/device_tree.c
> @@ -71,7 +71,9 @@ void *load_device_tree(const char *filename_path, int
> *sizep)
> int ret;
> void *fdt = NULL;
>
> - *sizep = 0;
> + if (sizep) {
> + *sizep = 0;
> + }
> dt_size = get_image_size(filename_path);
> if (dt_size < 0) {
> printf("Unable to get size of device tree file '%s'\n",
> @@ -104,7 +106,9 @@ void *load_device_tree(const char *filename_path, int
> *sizep)
> filename_path);
> goto fail;
> }
> - *sizep = dt_size;
> + if (sizep) {
> + *sizep = dt_size;
> + }
What can the caller do with this void* buffer without knowing its size?
They cannot hand the buffer to the guest unless they duplicate the
get_image_size() call, which is pointless, or we're assuming a fixed
size, which is unsafe. I'm asking what the legitimate use case for
sizep == NULL is?
Stefan
- [Qemu-trivial] [PULL 0/1] device_tree: load_device_tree(): Allow NULL sizep, Peter A. G. Crosthwaite, 2012/08/09
- [Qemu-trivial] [PATCH] device_tree: load_device_tree(): Allow NULL sizep, Peter A. G. Crosthwaite, 2012/08/09
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep,
Stefan Hajnoczi <=
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep, Peter Crosthwaite, 2012/08/10
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep, Stefan Hajnoczi, 2012/08/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep, Stefan Hajnoczi, 2012/08/15
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep, David Gibson, 2012/08/15
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep, Stefan Hajnoczi, 2012/08/20