[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] qemu-sockets: Fix potential memory leak
From: |
Stefan Weil |
Subject: |
[Qemu-trivial] [PATCH] qemu-sockets: Fix potential memory leak |
Date: |
Sat, 1 Sep 2012 09:40:26 +0200 |
The old code leaks variable 'peer'.
Signed-off-by: Stefan Weil <address@hidden>
---
qemu-sockets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Report from smatch:
qemu-sockets.c:404 inet_dgram_opts(101) warn: variable dereferenced before
check 'peer' (see line 401)
It looks like this warning does not make sense, but nevertheless
it helped me to discover the leak.
Regards,
Stefan Weil
diff --git a/qemu-sockets.c b/qemu-sockets.c
index 361d890..037775b 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -353,7 +353,7 @@ int inet_dgram_opts(QemuOpts *opts)
if (0 != (rc = getaddrinfo(addr, port, &ai, &local))) {
fprintf(stderr,"getaddrinfo(%s,%s): %s\n", addr, port,
gai_strerror(rc));
- return -1;
+ goto err;
}
/* create socket */
--
1.7.10
- [Qemu-trivial] [PATCH] qemu-sockets: Fix potential memory leak,
Stefan Weil <=